-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][E2E] Build test output to separate files #15631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but if we are going to rely on this for some CI optimizations we prolly need some CI check to make sure nobody adds a new test reusing the same file
A note, the test |
This PR includes only trivial E2E test changes, so merging with failed test-perf (AMD system) task. |
Currently, many tests that need to check executables built in different ways will build over the same output file. This patch edits these tests to instead build each executable to a different output file.
This should not have any functional differences in behavior, however it will help us later if we want to cache the built executables to run seperately.